Re: Problem with tap2dsk
Posted: Sun May 11, 2014 10:10 am
Hello, hello.
People, we need to be careful with the changes we are doing.
Right now, Jylam is doing changes to port the OSDK to Linux, and Hialmar has made some changes to Tap2Dsk, and in both cases the code stopped compiling in VisualStudio so I had to spend some time fixing it.
So we need some rules:
- Check if you have VisualStudio that it still works
- Don't assume that all plateforms are POSIX (hint: #include <unistd.h> is not available in VisualStudio)
- When you add new commands, check that the required includes are there (hint: exit() requires #include <stdlib.h> (or cstdlib in a cpp file))
- Don't assume that all compiles are following C99, so do not declare variables in the middle of functions without a {} in a C program
- If you don't use a variable, remove it: I'm compiling with Warnings as errors on as many modules I can, so it complains about unused variables.
And very important:
- If you add features and bug fixes, please bump up the version number! (Else we can't differentiate Tap2Dsk v2.1 from the v2.1 without the bugs)
People, we need to be careful with the changes we are doing.
Right now, Jylam is doing changes to port the OSDK to Linux, and Hialmar has made some changes to Tap2Dsk, and in both cases the code stopped compiling in VisualStudio so I had to spend some time fixing it.
So we need some rules:
- Check if you have VisualStudio that it still works
- Don't assume that all plateforms are POSIX (hint: #include <unistd.h> is not available in VisualStudio)
- When you add new commands, check that the required includes are there (hint: exit() requires #include <stdlib.h> (or cstdlib in a cpp file))
- Don't assume that all compiles are following C99, so do not declare variables in the middle of functions without a {} in a C program
- If you don't use a variable, remove it: I'm compiling with Warnings as errors on as many modules I can, so it complains about unused variables.
And very important:
- If you add features and bug fixes, please bump up the version number! (Else we can't differentiate Tap2Dsk v2.1 from the v2.1 without the bugs)